phet commented on code in PR #4067:
URL: https://github.com/apache/gobblin/pull/4067#discussion_r1805165363
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -173,6 +174,8 @@ public class GobblinYarnAppLauncher {
private static final String GOBBLIN_YARN_APPLICATION_TYPE = "GOBBLIN_YARN";
+ private static final String APPLICATION_TAGS_KEY =
"hadoop-inject.mapreduce.job.tags";
Review Comment:
to anticipate confusion, this may be worth a code comment, that even though
this is named for an MR prop:
https://hadoop.apache.org/docs/stable/hadoop-mapreduce-client/hadoop-mapreduce-client-core/mapred-default.xml
that it's essentially morphed into a general-purpose pass-through for
Azkaban to provide context about its execution
the `hadoop-inject.` prefix is documented here -
https://azkaban.readthedocs.io/en/latest/jobTypes.html#id4
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
