Will-Lo commented on code in PR #4069:
URL: https://github.com/apache/gobblin/pull/4069#discussion_r1809781895
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/hive/HiveDatasetFinder.java:
##########
@@ -294,6 +304,12 @@ protected HiveDataset computeNext() {
};
}
+ protected static boolean shouldAllowTableLocation(Optional<String> regex,
Table table) {
+ if (!regex.isPresent()) {
+ return true;
+ }
+ return
Pattern.compile(regex.get()).matcher(table.getSd().getLocation()).matches();
Review Comment:
I compiled it as part of the class field instead, good callout
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
