Blazer-007 commented on code in PR #4058:
URL: https://github.com/apache/gobblin/pull/4058#discussion_r1810304986
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/BaseIcebergCatalog.java:
##########
@@ -43,7 +44,10 @@ protected BaseIcebergCatalog(String catalogName, Class<?
extends Catalog> compan
@Override
public IcebergTable openTable(String dbName, String tableName) {
TableIdentifier tableId = TableIdentifier.of(dbName, tableName);
- return new IcebergTable(tableId, calcDatasetDescriptorName(tableId),
getDatasetDescriptorPlatform(), createTableOperations(tableId),
this.getCatalogUri());
+ return new IcebergTable(tableId, calcDatasetDescriptorName(tableId),
getDatasetDescriptorPlatform(),
+ createTableOperations(tableId),
+ this.getCatalogUri(),
+ loadTableInstance(tableId));
Review Comment:
Yes it arise from `loadTableInstance` or more specifically from
`catalog.loadTable(tableIdentifier)` and i dont believe it will be easy to
catch it and rethrow as `IcebergTable.TableNotFoundException` because this
exception arises before creating IcebergTable instance itself as opposite to
catalog.newTableOps(tableIdentifier) which doesn't throw this exception while
initializing rather it throws when used for first time inside IcebergTable.
Please let me know your thoughts on this if we really want to throw
`IcebergTable.TableNotFoundException` itself in catalog only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
