[ 
https://issues.apache.org/jira/browse/GOBBLIN-2163?focusedWorklogId=939984&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-939984
 ]

ASF GitHub Bot logged work on GOBBLIN-2163:
-------------------------------------------

                Author: ASF GitHub Bot
            Created on: 24/Oct/24 16:38
            Start Date: 24/Oct/24 16:38
    Worklog Time Spent: 10m 
      Work Description: Blazer-007 commented on code in PR #4064:
URL: https://github.com/apache/gobblin/pull/4064#discussion_r1815367922


##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergTableMetadataValidatorUtils.java:
##########
@@ -0,0 +1,96 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.gobblin.data.management.copy.iceberg;
+
+import java.io.IOException;
+
+import org.apache.iceberg.PartitionSpec;
+import org.apache.iceberg.Schema;
+import org.apache.iceberg.TableMetadata;
+
+import lombok.extern.slf4j.Slf4j;
+
+/**
+ * Validator for Iceberg table metadata, ensuring that the source and 
destination tables have
+ * compatible schemas and partition specifications.
+ */
+@Slf4j
+public class IcebergTableMetadataValidatorUtils {
+
+  private IcebergTableMetadataValidatorUtils() {
+    // Do not instantiate
+  }
+
+  /**
+   * Validates the metadata of the source and destination Iceberg tables.
+   *
+   * @param srcTableMetadata  the metadata of the source table
+   * @param destTableMetadata the metadata of the destination table
+   * @throws IOException if the schemas or partition specifications do not 
match
+   */
+  public static void validateSourceAndDestinationTablesMetadata(TableMetadata 
srcTableMetadata,

Review Comment:
   Thanks for this suggestion, let me correct the naming in this class as well 
as test.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 939984)
    Time Spent: 50m  (was: 40m)

> Add IcebergTable Metadata Validator 
> ------------------------------------
>
>                 Key: GOBBLIN-2163
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-2163
>             Project: Apache Gobblin
>          Issue Type: Task
>            Reporter: Vivek Rai
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> Add a new class IcebergTableMetadataValidator which should validates table 
> metadata like schema partition spec between two iceberg tables



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to