[
https://issues.apache.org/jira/browse/GOBBLIN-2163?focusedWorklogId=940577&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-940577
]
ASF GitHub Bot logged work on GOBBLIN-2163:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Oct/24 21:11
Start Date: 28/Oct/24 21:11
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4064:
URL: https://github.com/apache/gobblin/pull/4064#discussion_r1819766989
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergPartitionDatasetFinder.java:
##########
@@ -38,6 +38,9 @@
public class IcebergPartitionDatasetFinder extends IcebergDatasetFinder {
public static final String ICEBERG_PARTITION_NAME_KEY = "partition.name";
public static final String ICEBERG_PARTITION_VALUE_KEY = "partition.value";
+ public static final String
ICEBERG_DATASET_VALIDATE_STRICT_PARTITION_EQUALITY = ICEBERG_DATASET_PREFIX +
"validate.strict.partition.equality";
Review Comment:
considering again the naming through fresh eyes, it ought to be
`partition.validate.strict.equality`, so the fully-qualified form begins w/
`iceberg.dataset.partition.`. that's essentially the type of iceberg dataset
here and if we later have additional configs for iceberg-partition copy, that
should be the common prefix for them too.
the current alt. here mixes the `.partition.` in closer to the end, where
the semantics get lost
Issue Time Tracking
-------------------
Worklog Id: (was: 940577)
Time Spent: 2h 50m (was: 2h 40m)
> Add IcebergTable Metadata Validator
> ------------------------------------
>
> Key: GOBBLIN-2163
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2163
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
> Add a new class IcebergTableMetadataValidator which should validates table
> metadata like schema partition spec between two iceberg tables
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
