[
https://issues.apache.org/jira/browse/GOBBLIN-2169?focusedWorklogId=941602&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-941602
]
ASF GitHub Bot logged work on GOBBLIN-2169:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/24 04:45
Start Date: 04/Nov/24 04:45
Worklog Time Spent: 10m
Work Description: Blazer-007 opened a new pull request, #4073:
URL: https://github.com/apache/gobblin/pull/4073
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [✔️] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2169
### Description
- [✔️] Here are some details about my PR, including screenshots (if
applicable):
NPE can occur if table has no previous snapshot to copy data files from. My
changes aim to fix this and throw io exception incase no snapshot found for
copying in place of unexpected NPE.
### Tests
- [✔️] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
testGetPartitionSpecificDataFilesThrowsExceptionWhenNoSnapshotsFound
### Commits
- [✔️] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 941602)
Time Spent: 0.5h (was: 20m)
> Fix NPE in overwritePartition
> -----------------------------
>
> Key: GOBBLIN-2169
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2169
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> While overwrite we log the snapshot id of last snapshot present before
> commit, incase table has no previous snapshot it will give NPE
> Line giving NPE -
> {code:java}
> log.info("~{}~ SnapshotId before overwrite: {}", tableId,
> accessTableMetadata().currentSnapshot().snapshotId());{code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
