phet commented on code in PR #4075:
URL: https://github.com/apache/gobblin/pull/4075#discussion_r1840935265
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/YarnService.java:
##########
@@ -240,6 +242,13 @@ public YarnService(Config config, String applicationName,
String applicationId,
Optional.of(config.getString(GobblinYarnConfigurationKeys.CONTAINER_JVM_ARGS_KEY))
:
Optional.<String>absent();
+ String proxyConfigValue =
config.hasPath(GobblinYarnConfigurationKeys.YARN_APPLICATION_PROXY_JVM_ARGS) ?
+
config.getString(GobblinYarnConfigurationKeys.YARN_APPLICATION_PROXY_JVM_ARGS)
: StringUtils.EMPTY;
+
+ //We get config value as emptyStringPlaceholder when the string is
actually supposed to be empty
+ this.proxyJvmArgs =
proxyConfigValue.contains(GobblinYarnConfigurationKeys.EMPTY_STRING_PLACEHOLDER)
+ ? StringUtils.EMPTY : proxyConfigValue;
Review Comment:
as you set it to empty when
`!config.hasPath(GobblinYarnConfigurationKeys.YARN_APPLICATION_PROXY_JVM_ARGS)`,
what does this placeholder allow that just leaving out the property (or
setting it to empty) would not?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
