[
https://issues.apache.org/jira/browse/GOBBLIN-2173?focusedWorklogId=944376&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-944376
]
ASF GitHub Bot logged work on GOBBLIN-2173:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Nov/24 15:14
Start Date: 19/Nov/24 15:14
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #4076:
URL: https://github.com/apache/gobblin/pull/4076#issuecomment-2485996075
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/4076?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
All modified and coverable lines are covered by tests :white_check_mark:
> Project coverage is 41.32%. Comparing base
[(`edaf474`)](https://app.codecov.io/gh/apache/gobblin/commit/edaf474accf85539156b95b121b2e49bba75d4b1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`7d2b49f`)](https://app.codecov.io/gh/apache/gobblin/commit/7d2b49f16a840a9a4a99e9274a915ab189ababff?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 2 commits behind head on master.
> :exclamation: There is a different number of reports uploaded between
BASE (edaf474) and HEAD (7d2b49f). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (edaf474) | HEAD (7d2b49f) |
>|------|------|------|
>||2|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4076 +/- ##
=============================================
- Coverage 51.47% 41.32% -10.15%
+ Complexity 7546 2237 -5309
=============================================
Files 1386 486 -900
Lines 52105 20614 -31491
Branches 5727 2385 -3342
=============================================
- Hits 26821 8519 -18302
+ Misses 22990 11195 -11795
+ Partials 2294 900 -1394
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/4076?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
----
🚨 Try these New Features:
- [Flaky Tests
Detection](https://docs.codecov.com/docs/test-result-ingestion-beta) - Detect
and resolve failed and flaky tests
- [JS Bundle
Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis) - Avoid
shipping oversized bundles
Issue Time Tracking
-------------------
Worklog Id: (was: 944376)
Time Spent: 4h 50m (was: 4h 40m)
> Adhoc flows are not being deleted from GaaS FlowSpec store
> ----------------------------------------------------------
>
> Key: GOBBLIN-2173
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2173
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Abhishek Jain
> Assignee: Abhishek Tiwari
> Priority: Critical
> Time Spent: 4h 50m
> Remaining Estimate: 0h
>
> In GaaS, we store adhoc flows temporarily in our flowspec DB in order to
> persist them in service restart/failover scenarios. However, it is expected
> that once these flows are kicked off/ forwarded to the DagProcEngine, they
> need to be removed from our flowspec db.
> This is currently not consistently happening, there seems to be some edge
> case(s) where they are persisted in the db. This can be fatal for users such
> as DIL that run adhoc flows using the same flowgroup/flowname consistently,
> which will lead to their flows being stuck. We need to find which edge cases
> are not handling the flow spec deletion properly.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
