[
https://issues.apache.org/jira/browse/GOBBLIN-2174?focusedWorklogId=945672&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-945672
]
ASF GitHub Bot logged work on GOBBLIN-2174:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 26/Nov/24 09:50
Start Date: 26/Nov/24 09:50
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4077:
URL: https://github.com/apache/gobblin/pull/4077#discussion_r1858105668
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/YarnService.java:
##########
@@ -440,7 +430,7 @@ public synchronized boolean
requestTargetNumberOfContainers(int numContainers, S
LOGGER.info("Trying to set numTargetContainers={}, in-use helix instances
count is {}, container map size is {}",
numContainers, inUseInstances.size(), this.containerMap.size());
- requestContainers(numContainers,
Resource.newInstance(defaultContainerMemoryMbs, defaultContainerCores));
+ requestContainers(numContainers,
Resource.newInstance(defaultContainerMemoryMbs, defaultContainerCores),
Optional.absent());
Review Comment:
(WRT the enclosing method...)
does it need to be `public`? also, if it's only used by
`requestInitialContainers` we might name it thus. on the other hand, why
special case the reading from `config`, rather than doing
`WorkerProfile.getConfig`?
Issue Time Tracking
-------------------
Worklog Id: (was: 945672)
Time Spent: 0.5h (was: 20m)
> Add GoT YarnService integration with DynamicScaling
> ---------------------------------------------------
>
> Key: GOBBLIN-2174
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2174
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Vivek Rai
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> After dynamic scaling implemented as part of
> https://issues.apache.org/jira/browse/GOBBLIN-2170 , the Temporal Yarn
> Service needs to be integrated with the dynamic scaling to have fully
> functional dynamic scalable yarn service.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
