[
https://issues.apache.org/jira/browse/GOBBLIN-2175?focusedWorklogId=945798&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-945798
]
ASF GitHub Bot logged work on GOBBLIN-2175:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Nov/24 06:20
Start Date: 27/Nov/24 06:20
Worklog Time Spent: 10m
Work Description: pratapaditya04 opened a new pull request, #4078:
URL: https://github.com/apache/gobblin/pull/4078
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [ ] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-2175] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-2175
### Description
- [ ] Here are some details about my PR, including screenshots (if
applicable):
Partial commit support was introduced in this PR
https://github.com/apache/gobblin/pull/4066 , This feature is not working as
expected in temporal execution.
When a ProcessWorkUnit activity encounters an Exception and exhausts the
configured number of retries, it causes the parent NestingExecWorkUnits
workflow to fail. This failure propagates upwards, resulting in a
ChildWorkflowExecutionFailed for the next enclosing parent,
ProcessWorkUnitsImpl. Consequently, the CommitStepWorkflow, which is crucial
for file-level commit, does not execute. The file rename into the final
destination occurs during the commit step, not within the task itself. This
issue disrupts the workflow, as the commit step is essential for completing the
file-level commit process.
To address this, we modify ProcessWorkUnitsImpl to catch the child workflow
failure and still perform the CommitStepWorkflow before exiting.
### Tests
- [ ] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
### Commits
- [ ] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
Issue Time Tracking
-------------------
Worklog Id: (was: 945798)
Remaining Estimate: 0h
Time Spent: 10m
> Fix partial commit in temporal flow
> -----------------------------------
>
> Key: GOBBLIN-2175
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2175
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Aditya Pratap Singh
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Fix partial commit in temporal flow
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
