[
https://issues.apache.org/jira/browse/GOBBLIN-2176?focusedWorklogId=946400&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-946400
]
ASF GitHub Bot logged work on GOBBLIN-2176:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/24 21:06
Start Date: 02/Dec/24 21:06
Worklog Time Spent: 10m
Work Description: phet commented on code in PR #4079:
URL: https://github.com/apache/gobblin/pull/4079#discussion_r1866615709
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/cluster/GobblinTemporalTaskRunner.java:
##########
@@ -224,6 +225,9 @@ public void start()
// Add a shutdown hook so the task scheduler gets properly shutdown
addShutdownHook();
+ // Update authenticator if set
+
AbstractJobLauncher.setDefaultAuthenticator(ConfigUtils.configToProperties(this.clusterConfig));
Review Comment:
`configToProperties` is somewhat expensive, but since this happens only once
at start-up and not in the fast path, that should NOT be a large concern here
Issue Time Tracking
-------------------
Worklog Id: (was: 946400)
Remaining Estimate: 0h
Time Spent: 10m
> Set default authenticator in Temporal containers
> ------------------------------------------------
>
> Key: GOBBLIN-2176
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2176
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-service
> Reporter: Abhishek Jain
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> Currently in
> [MRJobLauncher|https://github.com/apache/gobblin/blob/e5d897edaee391d05a55e6ac8a420e3416fef6d9/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/mapreduce/MRJobLauncher.java#L833]
> as well as
> [AbstractJobLauncher|https://github.com/apache/gobblin/blob/e5d897edaee391d05a55e6ac8a420e3416fef6d9/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java#L222C7-L222C30]
> we set default authenticator if the job contains the property
> "job.default.authenticator.class"
>
> This behaviour doesn't exist in Temporal worker containers because we don't
> extend from AbstractJobLauncher or set the authenticator explicitly.
>
> The authenticator is set in Temporal AM however, since we extend
> AbstractJobLauncher in GobblinTemporalJobLauncher (through
> GobblinJobLauncher) and the call to set default authenticator is made in the
> [constructor|https://github.com/apache/gobblin/blob/e5d897edaee391d05a55e6ac8a420e3416fef6d9/gobblin-runtime/src/main/java/org/apache/gobblin/runtime/AbstractJobLauncher.java#L222C7-L222C30]
> of AbstractJobLauncher.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
