Blazer-007 commented on code in PR #4077:
URL: https://github.com/apache/gobblin/pull/4077#discussion_r1875665922
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/YarnService.java:
##########
@@ -558,8 +556,11 @@ protected ByteBuffer getSecurityTokens() throws
IOException {
protected String buildContainerCommand(Container container, String
helixParticipantId, String helixInstanceTag) {
long allocationRequestId = container.getAllocationRequestId();
// Using getOrDefault for backward-compatibility with containers that
don't have allocationRequestId set
- WorkerProfile workerProfile =
this.workerProfileByAllocationRequestId.getOrDefault(allocationRequestId,
- this.defaultWorkerProfile);
+ WorkerProfile workerProfile =
Optional.fromNullable(this.workerProfileByAllocationRequestId.get(allocationRequestId))
+ .or(() -> {
+ LOGGER.warn("No Worker Profile found for {} ... falling back... ",
allocationRequestId);
Review Comment:
Thanks for this suggestion, adding the same
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
