[
https://issues.apache.org/jira/browse/GOBBLIN-2174?focusedWorklogId=947262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-947262
]
ASF GitHub Bot logged work on GOBBLIN-2174:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Dec/24 09:41
Start Date: 09/Dec/24 09:41
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4077:
URL: https://github.com/apache/gobblin/pull/4077#discussion_r1875665922
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/YarnService.java:
##########
@@ -558,8 +556,11 @@ protected ByteBuffer getSecurityTokens() throws
IOException {
protected String buildContainerCommand(Container container, String
helixParticipantId, String helixInstanceTag) {
long allocationRequestId = container.getAllocationRequestId();
// Using getOrDefault for backward-compatibility with containers that
don't have allocationRequestId set
- WorkerProfile workerProfile =
this.workerProfileByAllocationRequestId.getOrDefault(allocationRequestId,
- this.defaultWorkerProfile);
+ WorkerProfile workerProfile =
Optional.fromNullable(this.workerProfileByAllocationRequestId.get(allocationRequestId))
+ .or(() -> {
+ LOGGER.warn("No Worker Profile found for {} ... falling back... ",
allocationRequestId);
Review Comment:
Thanks for this suggestion, adding the same
Issue Time Tracking
-------------------
Worklog Id: (was: 947262)
Time Spent: 5h 10m (was: 5h)
> Add GoT YarnService integration with DynamicScaling
> ---------------------------------------------------
>
> Key: GOBBLIN-2174
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2174
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Vivek Rai
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 5h 10m
> Remaining Estimate: 0h
>
> After dynamic scaling implemented as part of
> https://issues.apache.org/jira/browse/GOBBLIN-2170 , the Temporal Yarn
> Service needs to be integrated with the dynamic scaling to have fully
> functional dynamic scalable yarn service.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
