Blazer-007 opened a new pull request, #4085: URL: https://github.com/apache/gobblin/pull/4085
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-2182 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): - Added cleanup for GoT execution controlled with a config - `"gobblin.temporal.clean.up.work.dir"` ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: - Tested using e2e run ``` 2024-12-11 09:32:34 PST [,,] INFO [FsJobConfigurationManager STARTING] org.apache.gobblin.temporal.joblauncher.GobblinJobLauncher - Deleting persisted work units for job job_virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324 2024-12-11 09:32:34 PST [,,] INFO [FsJobConfigurationManager STARTING] org.apache.gobblin.temporal.joblauncher.GobblinJobLauncher - Deleting job state file for job job_virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324 2024-12-11 09:32:34 PST [,,] INFO [FsJobConfigurationManager STARTING] org.apache.gobblin.cluster.GobblinClusterUtils - job state file path: hdfs://ltx1-holdem/jobs/gobblintest/gaas-temporal-workdir/gobblin-ddm/virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324_121377163/job_virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324.job.state 2024-12-11 09:32:34 PST [,,] INFO [FsJobConfigurationManager STARTING] org.apache.gobblin.temporal.joblauncher.GobblinJobLauncher - Cleaning up work directory : /tmp/gobblintest/gobblin/jobRootDir/virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843/job_virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324 for job : job_virai_got_retry_test_dec_11_8_Distcp_holdem-tl_holdem-tl_distcp-push-generic_794995843_1733937791324 ``` ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
