phet commented on code in PR #4087:
URL: https://github.com/apache/gobblin/pull/4087#discussion_r1891087153
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/worker/WorkFulfillmentWorker.java:
##########
@@ -48,14 +49,14 @@ public WorkFulfillmentWorker(Config config, WorkflowClient
workflowClient) {
@Override
protected Class<?>[] getWorkflowImplClasses() {
- return new Class[] { CommitStepWorkflowImpl.class,
ExecuteGobblinWorkflowImpl.class, GenerateWorkUnitsWorkflowImpl.class,
- NestingExecOfProcessWorkUnitWorkflowImpl.class,
ProcessWorkUnitsWorkflowImpl.class };
+ return new Class[] { ExecuteGobblinWorkflowImpl.class,
ProcessWorkUnitsWorkflowImpl.class,
NestingExecOfProcessWorkUnitWorkflowImpl.class,
+ CommitStepWorkflowImpl.class, GenerateWorkUnitsWorkflowImpl.class
};
}
@Override
protected Object[] getActivityImplInstances() {
- return new Object[] { new CommitActivityImpl(), new
DeleteWorkDirsActivityImpl(),new GenerateWorkUnitsImpl(),
- new ProcessWorkUnitImpl(), new SubmitGTEActivityImpl()};
+ return new Object[] { new SubmitGTEActivityImpl(), new
GenerateWorkUnitsImpl(), new RecommendScalingForWorkUnitsLinearHeuristicImpl(),
new ProcessWorkUnitImpl(),
+ new CommitActivityImpl(), new DeleteWorkDirsActivityImpl() };
Review Comment:
I just put them in the sequential order of when they run. (not anything
particularly important that I'm committed to.)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
