[
https://issues.apache.org/jira/browse/GOBBLIN-2186?focusedWorklogId=950611&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-950611
]
ASF GitHub Bot logged work on GOBBLIN-2186:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 01/Jan/25 16:36
Start Date: 01/Jan/25 16:36
Worklog Time Spent: 10m
Work Description: codecov-commenter commented on PR #4089:
URL: https://github.com/apache/gobblin/pull/4089#issuecomment-2567072449
##
[Codecov](https://app.codecov.io/gh/apache/gobblin/pull/4089?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
Report
Attention: Patch coverage is `2.04082%` with `48 lines` in your changes
missing coverage. Please review.
> Project coverage is 42.95%. Comparing base
[(`003590e`)](https://app.codecov.io/gh/apache/gobblin/commit/003590e7d58691505d8fb73988db35ae636873f1?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
to head
[(`8ce206d`)](https://app.codecov.io/gh/apache/gobblin/commit/8ce206d078e186360697b88bf7165dca26165d15?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
> Report is 5 commits behind head on master.
| [Files with missing
lines](https://app.codecov.io/gh/apache/gobblin/pull/4089?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
| Patch % | Lines |
|---|---|---|
|
[...temporal/workflows/metrics/TemporalEventTimer.java](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fworkflows%2Fmetrics%2FTemporalEventTimer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC93b3JrZmxvd3MvbWV0cmljcy9UZW1wb3JhbEV2ZW50VGltZXIuamF2YQ==)
| 0.00% | [20 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...obblin/temporal/ddm/work/WorkUnitsSizeSummary.java](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fddm%2Fwork%2FWorkUnitsSizeSummary.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vd29yay9Xb3JrVW5pdHNTaXplU3VtbWFyeS5qYXZh)
| 0.00% | [13 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...poral/ddm/activity/impl/GenerateWorkUnitsImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fddm%2Factivity%2Fimpl%2FGenerateWorkUnitsImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vYWN0aXZpdHkvaW1wbC9HZW5lcmF0ZVdvcmtVbml0c0ltcGwuamF2YQ==)
| 0.00% | [7 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...oral/ddm/workflow/impl/CommitStepWorkflowImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fddm%2Fworkflow%2Fimpl%2FCommitStepWorkflowImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vd29ya2Zsb3cvaW1wbC9Db21taXRTdGVwV29ya2Zsb3dJbXBsLmphdmE=)
| 0.00% | [2 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[.../ddm/workflow/impl/ExecuteGobblinWorkflowImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fddm%2Fworkflow%2Fimpl%2FExecuteGobblinWorkflowImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vd29ya2Zsb3cvaW1wbC9FeGVjdXRlR29iYmxpbldvcmtmbG93SW1wbC5qYXZh)
| 33.33% | [2 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...gobblin/temporal/workflows/metrics/EventTimer.java](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fworkflows%2Fmetrics%2FEventTimer.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC93b3JrZmxvd3MvbWV0cmljcy9FdmVudFRpbWVyLmphdmE=)
| 0.00% | [2 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...dm/workflow/impl/ProcessWorkUnitsWorkflowImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fddm%2Fworkflow%2Fimpl%2FProcessWorkUnitsWorkflowImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC9kZG0vd29ya2Zsb3cvaW1wbC9Qcm9jZXNzV29ya1VuaXRzV29ya2Zsb3dJbXBsLmphdmE=)
| 0.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
|
[...ral/workflows/helloworld/GreetingWorkflowImpl.java](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&filepath=gobblin-temporal%2Fsrc%2Fmain%2Fjava%2Forg%2Fapache%2Fgobblin%2Ftemporal%2Fworkflows%2Fhelloworld%2FGreetingWorkflowImpl.java&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#diff-Z29iYmxpbi10ZW1wb3JhbC9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvZ29iYmxpbi90ZW1wb3JhbC93b3JrZmxvd3MvaGVsbG93b3JsZC9HcmVldGluZ1dvcmtmbG93SW1wbC5qYXZh)
| 0.00% | [1 Missing :warning:
](https://app.codecov.io/gh/apache/gobblin/pull/4089?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
|
> :exclamation: There is a different number of reports uploaded between
BASE (003590e) and HEAD (8ce206d). Click for more details.
>
> <details><summary>HEAD has 1 upload less than BASE</summary>
>
>| Flag | BASE (003590e) | HEAD (8ce206d) |
>|------|------|------|
>||2|1|
></details>
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #4089 +/- ##
============================================
- Coverage 47.98% 42.95% -5.03%
+ Complexity 8373 2436 -5937
============================================
Files 1582 507 -1075
Lines 62712 21403 -41309
Branches 7105 2456 -4649
============================================
- Hits 30091 9194 -20897
+ Misses 29899 11272 -18627
+ Partials 2722 937 -1785
```
</details>
[:umbrella: View full report in Codecov by
Sentry](https://app.codecov.io/gh/apache/gobblin/pull/4089?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it
here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
Issue Time Tracking
-------------------
Worklog Id: (was: 950611)
Time Spent: 20m (was: 10m)
> Ensure GoT jobs record Work Discovery planning timing for populating the
> `GaaSJobObservabilityEvent` fields `jobPlanning{Start,End}Timestamp`
> ---------------------------------------------------------------------------------------------------------------------------------------------
>
> Key: GOBBLIN-2186
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2186
> Project: Apache Gobblin
> Issue Type: New Feature
> Components: gobblin-core
> Reporter: Kip Kohn
> Assignee: Abhishek Tiwari
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> `GaaSJobObservabilityEvent`s for Gobblin-on-Temporal jobs have no values set
> for the fields `jobPlanningStartTimestamp` and `jobPlanningEndTimestamp`
> because no `TimingEvent.LauncherTimings.WORK_UNITS_CREATION` GTE (to record
> those values) is emitted by `GenerateWorkUnitsImpl`
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
