[
https://issues.apache.org/jira/browse/GOBBLIN-2187?focusedWorklogId=951025&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-951025
]
ASF GitHub Bot logged work on GOBBLIN-2187:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 06/Jan/25 13:02
Start Date: 06/Jan/25 13:02
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4090:
URL: https://github.com/apache/gobblin/pull/4090#discussion_r1904125958
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/activity/impl/GenerateWorkUnitsImpl.java:
##########
@@ -95,7 +95,11 @@ public WorkUnitsSizeSummary asSizeSummary(int numQuantiles) {
private static List<Double> getQuantiles(TDigest digest, int numQuantiles)
{
List<Double> quantileMinSizes = Lists.newArrayList();
for (int i = 1; i <= numQuantiles; i++) {
- quantileMinSizes.add(digest.quantile((i * 1.0) / numQuantiles));
+ double currQuantileMinSize = digest.quantile((i * 1.0) / numQuantiles);
+ if (Double.isNaN(currQuantileMinSize)) {
+ currQuantileMinSize = 0.0;
+ }
+ quantileMinSizes.add(currQuantileMinSize);
Review Comment:
NaN comes from this `digest.quantile((i * 1.0) / numQuantiles)` i.e.
quantile(...) function
Issue Time Tracking
-------------------
Worklog Id: (was: 951025)
Time Spent: 0.5h (was: 20m)
> Fix NaN issue while generating WUSizeSummary
> --------------------------------------------
>
> Key: GOBBLIN-2187
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2187
> Project: Apache Gobblin
> Issue Type: Bug
> Components: gobblin-core
> Reporter: Vivek Rai
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> Recently GoT executions were enhanced to return WUSizeSummary with more info,
> but in case workunits are zero those have NaN value due to divide by zero
> case,
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
