[
https://issues.apache.org/jira/browse/GOBBLIN-2182?focusedWorklogId=951308&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-951308
]
ASF GitHub Bot logged work on GOBBLIN-2182:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 08/Jan/25 08:16
Start Date: 08/Jan/25 08:16
Worklog Time Spent: 10m
Work Description: khandelwal-prateek commented on code in PR #4085:
URL: https://github.com/apache/gobblin/pull/4085#discussion_r1906552495
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -43,6 +43,8 @@ public interface GobblinTemporalConfigurationKeys {
String GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_PREFIX =
GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "arg.";
String GOBBLIN_TEMPORAL_JOB_LAUNCHER_CONFIG_OVERRIDES =
GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "config.overrides";
+ String GOBBLIN_TEMPORAL_CLEAN_UP_WORK_DIR = PREFIX + "clean.up.work.dir";
Review Comment:
cleanup should be used as a single word..
`GOBBLIN_TEMPORAL_WORK_DIR_CLEANUP_ENABLED = PREFIX +
"work.dir.cleanup.enabled"`
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -43,6 +43,8 @@ public interface GobblinTemporalConfigurationKeys {
String GOBBLIN_TEMPORAL_JOB_LAUNCHER_ARG_PREFIX =
GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "arg.";
String GOBBLIN_TEMPORAL_JOB_LAUNCHER_CONFIG_OVERRIDES =
GOBBLIN_TEMPORAL_JOB_LAUNCHER_PREFIX + "config.overrides";
+ String GOBBLIN_TEMPORAL_CLEAN_UP_WORK_DIR = PREFIX + "clean.up.work.dir";
+ String DEFAULT_GOBBLIN_TEMPORAL_CLEAN_UP_WORK_DIR = "true";
Review Comment:
as this is a boolean, can be renamed to
`DEFAULT_GOBBLIN_TEMPORAL_WORK_DIR_CLEANUP_ENABLED`
Issue Time Tracking
-------------------
Worklog Id: (was: 951308)
Time Spent: 20m (was: 10m)
> Cleanup workdir in Gobblin-on-Temporal execution
> ------------------------------------------------
>
> Key: GOBBLIN-2182
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2182
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Vivek Rai
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
