[
https://issues.apache.org/jira/browse/GOBBLIN-2183?focusedWorklogId=953313&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-953313
]
ASF GitHub Bot logged work on GOBBLIN-2183:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 21/Jan/25 10:48
Start Date: 21/Jan/25 10:48
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4086:
URL: https://github.com/apache/gobblin/pull/4086#discussion_r1923496725
##########
gobblin-service/src/main/java/org/apache/gobblin/service/monitoring/KafkaJobStatusMonitor.java:
##########
@@ -233,6 +234,12 @@ protected void
processMessage(DecodeableKafkaRecord<byte[],byte[]> message) {
// as much as FAILED does if we chose to emit ObservabilityEvent for
FAILED_PENDING_RETRY
boolean retryRequired = modifyStateIfRetryRequired(jobStatus);
+ if (Objects.equals(status, "COMPILED")) {
+ this.eventProducer.emitObservabilityEvent(jobStatus);
+ }
+ if (updatedJobStatus.getRight() == NewState.RUNNING) {
+ this.eventProducer.emitObservabilityEvent(jobStatus);
Review Comment:
Why this difference i.e. using `status` and `updatedJobStatus.getRight()`
for COMPILED and RUNNING ?
Issue Time Tracking
-------------------
Worklog Id: (was: 953313)
Remaining Estimate: 0h
Time Spent: 10m
> Add transition events to GaSJobObservabilityEventProducer
> ---------------------------------------------------------
>
> Key: GOBBLIN-2183
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2183
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Swapnil Palash
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
