[
https://issues.apache.org/jira/browse/GOBBLIN-2192?focusedWorklogId=955582&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-955582
]
ASF GitHub Bot logged work on GOBBLIN-2192:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 05/Feb/25 14:32
Start Date: 05/Feb/25 14:32
Worklog Time Spent: 10m
Work Description: Blazer-007 commented on code in PR #4095:
URL: https://github.com/apache/gobblin/pull/4095#discussion_r1943048684
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -74,4 +74,14 @@ public interface GobblinTemporalConfigurationKeys {
String DYNAMIC_SCALING_POLLING_INTERVAL_SECS = DYNAMIC_SCALING_PREFIX +
"polling.interval.seconds";
int DEFAULT_DYNAMIC_SCALING_POLLING_INTERVAL_SECS = 60;
+
+ /**
+ * Temporal metrics config properties
+ */
+ String TEMPORAL_METRICS_PREFIX = PREFIX + "metrics.";
+ String TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT = TEMPORAL_METRICS_PREFIX +
"otlp";
+ String TEMPORAL_METRICS_OTLP_HEADERS_KEY =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".headers";
+ String TEMPORAL_METRICS_REPORT_INTERVAL_SECS =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".report.interval.seconds";
+ int DEFAULT_TEMPORAL_METRICS_REPORT_INTERVAL_SECS = 10;
+ String TEMPORAL_METRICS_OTLP_DIMENSIONS_KEY =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".dimensions";
Review Comment:
What does these dimensions represent ?
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/GobblinTemporalConfigurationKeys.java:
##########
@@ -74,4 +74,14 @@ public interface GobblinTemporalConfigurationKeys {
String DYNAMIC_SCALING_POLLING_INTERVAL_SECS = DYNAMIC_SCALING_PREFIX +
"polling.interval.seconds";
int DEFAULT_DYNAMIC_SCALING_POLLING_INTERVAL_SECS = 60;
+
+ /**
+ * Temporal metrics config properties
+ */
+ String TEMPORAL_METRICS_PREFIX = PREFIX + "metrics.";
+ String TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT = TEMPORAL_METRICS_PREFIX +
"otlp";
+ String TEMPORAL_METRICS_OTLP_HEADERS_KEY =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".headers";
+ String TEMPORAL_METRICS_REPORT_INTERVAL_SECS =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".report.interval.seconds";
+ int DEFAULT_TEMPORAL_METRICS_REPORT_INTERVAL_SECS = 10;
+ String TEMPORAL_METRICS_OTLP_DIMENSIONS_KEY =
TEMPORAL_METRICS_OTLP_PREFIX_WITHOUT_DOT + ".dimensions";
Review Comment:
Also are these configs necessary to create i.e. cant we use open telemetry
configs & their passed values ?
Issue Time Tracking
-------------------
Worklog Id: (was: 955582)
Time Spent: 20m (was: 10m)
> Add Metrics support for Temporal workflows
> ------------------------------------------
>
> Key: GOBBLIN-2192
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2192
> Project: Apache Gobblin
> Issue Type: Task
> Components: gobblin-metrics
> Reporter: Abhishek Jain
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Add metrics support for Temporal workflow
> https://docs.temporal.io/references/sdk-metrics
> https://docs.temporal.io/develop/java/observability#metrics
> https://docs.micrometer.io/micrometer/reference/implementations/otlp.html
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
