abhishekmjain commented on code in PR #4097:
URL: https://github.com/apache/gobblin/pull/4097#discussion_r1955858685
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/cluster/GobblinTemporalTaskRunner.java:
##########
@@ -292,6 +293,12 @@ public synchronized void stop() {
this.containerMetrics.get().stopMetricsReporting();
}
+ try {
+ this.workflowServiceStubs.getOptions().getMetricsScope().close();
Review Comment:
It is because the metrics scope object has to be created separately and
passed to workflowServiceStubs. [See
here](https://github.com/apache/gobblin/blob/adef734100aa3eb076a0aeea8d202c4131543d02/gobblin-temporal/src/main/java/org/apache/gobblin/temporal/workflows/client/TemporalWorkflowClientFactory.java#L111-L114)
If metrics scope is shared and one of the consumer closes it, it would be
closed for all other consumers.
FYI This is temporal code, I am just guessing what could be the reason of
not closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
