[
https://issues.apache.org/jira/browse/GOBBLIN-2195?focusedWorklogId=957298&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957298
]
ASF GitHub Bot logged work on GOBBLIN-2195:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 17/Feb/25 06:52
Start Date: 17/Feb/25 06:52
Worklog Time Spent: 10m
Work Description: pratapaditya04 commented on code in PR #4098:
URL: https://github.com/apache/gobblin/pull/4098#discussion_r1957702136
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/cluster/GobblinTemporalTaskRunner.java:
##########
@@ -151,8 +151,7 @@ public GobblinTemporalTaskRunner(String applicationName,
this.containerMetrics = buildContainerMetrics();
this.numTemporalWorkers = ConfigUtils.getInt(config,
GobblinTemporalConfigurationKeys.TEMPORAL_NUM_WORKERS_PER_CONTAINER,
GobblinTemporalConfigurationKeys.DEFAULT_TEMPORAL_NUM_WORKERS_PER_CONTAINERS);
- this.temporalQueueName = ConfigUtils.getString(config,
GobblinTemporalConfigurationKeys.GOBBLIN_TEMPORAL_TASK_QUEUE,
- GobblinTemporalConfigurationKeys.DEFAULT_GOBBLIN_TEMPORAL_TASK_QUEUE);
+ this.temporalQueueName =
GobblinTemporalConfigurationKeys.getTemporalTaskQueueName(config);
Review Comment:
yeah,looks like dead code, temporalQueueName variable is not used. let me
clean it up
Issue Time Tracking
-------------------
Worklog Id: (was: 957298)
Time Spent: 1h (was: 50m)
> Update Temporal Task Queue Name due to length constraint
> --------------------------------------------------------
>
> Key: GOBBLIN-2195
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2195
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Aditya Pratap Singh
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> Update Temporal Task Queue Name due to length constraint
> . Keep it flowExecutionId_UUID to make it unique
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
