[
https://issues.apache.org/jira/browse/GOBBLIN-2189?focusedWorklogId=957843&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-957843
]
ASF GitHub Bot logged work on GOBBLIN-2189:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Feb/25 04:30
Start Date: 20/Feb/25 04:30
Worklog Time Spent: 10m
Work Description: khandelwal-prateek commented on code in PR #4092:
URL: https://github.com/apache/gobblin/pull/4092#discussion_r1962841974
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/yarn/AbstractDynamicScalingYarnServiceManager.java:
##########
@@ -110,9 +110,13 @@ public void run() {
List<ScalingDirective> scalingDirectives =
scalingDirectiveSource.getScalingDirectives();
if (CollectionUtils.isNotEmpty(scalingDirectives)) {
dynamicScalingYarnService.reviseWorkforcePlanAndRequestNewContainers(scalingDirectives);
+ } else {
+ dynamicScalingYarnService.calcDeltasAndRequestContainers();
}
} catch (FileNotFoundException fnfe) {
- log.warn("Failed to get scaling directives - " + fnfe.getMessage());
// important message, but no need for a stack trace
+ log.debug("Failed to get scaling directives - " + fnfe.getMessage());
// important message, but no need for a stack trace
Review Comment:
since this is expected in current system design and not a failure as such,
it would be good to change the debug log statement in that case to something
like:
`log.debug("Scaling directives file not found(possibly not yet created).
Falling back to delta calculation.");`
Issue Time Tracking
-------------------
Worklog Id: (was: 957843)
Time Spent: 4.5h (was: 4h 20m)
> Implement ContainerCompletion callback in DynamicScalingYarnService
> -------------------------------------------------------------------
>
> Key: GOBBLIN-2189
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2189
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-core
> Reporter: Vivek Rai
> Assignee: Abhishek Tiwari
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> DynamicScalingYarnService currently doesn't handle scaling down containers
> and neither does anything if container is killed abruptly or goes OOM. So to
> handle this scenario containerCompletion callback should be implemented to
> launch the replacement containers and also scaling down handling should be
> done.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
