abhishekmjain commented on code in PR #4108:
URL: https://github.com/apache/gobblin/pull/4108#discussion_r2052384155
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/work/assistance/Help.java:
##########
@@ -104,9 +103,9 @@ public static String
calcPerExecQualifierWithOptFlowExecId(FileSystemJobStateful
public static String calcPerExecQualifier(Config workerConfig) {
String userToProxy = workerConfig.hasPath(USER_TO_PROXY_KEY)
? workerConfig.getString(USER_TO_PROXY_KEY) : "";
- String azFlowExecId = workerConfig.hasPath(AZKABAN_FLOW_EXEC_ID_KEY)
- ? workerConfig.getString(AZKABAN_FLOW_EXEC_ID_KEY) :
UUID.randomUUID().toString();
- return userToProxy + "_" + azFlowExecId;
+ String gaasFlowExecId =
workerConfig.hasPath(ConfigurationKeys.GAAS_JOB_EXEC_ID)
+ ? workerConfig.getString(ConfigurationKeys.GAAS_JOB_EXEC_ID) :
UUID.randomUUID().toString();
Review Comment:
I believe this code is getting used only in executor where the jar will not
be updated during deployment, unlike service where the deployment will affect
currently running jobs.
Can you please confirm if that is the intention behind not adding a fallback
here?
Or is this getting used somewhere in service and we are still not adding a
fallback for some reason?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
