vsinghal85 commented on code in PR #4113:
URL: https://github.com/apache/gobblin/pull/4113#discussion_r2108403326
##########
gobblin-runtime/src/main/java/org/apache/gobblin/runtime/SafeDatasetCommit.java:
##########
@@ -90,6 +90,7 @@ public Void call()
metricContext = Instrumented.getMetricContext(datasetState,
SafeDatasetCommit.class);
finalizeDatasetStateBeforeCommit(this.datasetState);
+
this.datasetState.computeAndStoreQualityStatus(this.jobContext.getJobState());
Class<? extends DataPublisher> dataPublisherClass;
Review Comment:
Work unit is at individual task level, and if individual task data quality
fails, it does fail that task as well. Here in this method specifically we are
computing overall data quality of the dataset, based on data quality of all
individual tasks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
