[
https://issues.apache.org/jira/browse/GOBBLIN-2209?focusedWorklogId=972623&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-972623
]
ASF GitHub Bot logged work on GOBBLIN-2209:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/Jun/25 14:45
Start Date: 11/Jun/25 14:45
Worklog Time Spent: 10m
Work Description: Copilot commented on code in PR #4118:
URL: https://github.com/apache/gobblin/pull/4118#discussion_r2140394308
##########
gobblin-temporal/src/main/java/org/apache/gobblin/temporal/ddm/launcher/ExecuteGobblinJobLauncher.java:
##########
@@ -96,8 +103,21 @@ public void submitJob(List<WorkUnit> workunits) {
EventSubmitterContext eventSubmitterContext = new
EventSubmitterContext.Builder(eventSubmitter)
.withGaaSJobProps(finalProps)
.build();
+
+ Map<String, String> attributes = new HashMap<>();
+ attributes.put(CURR_STATE, JOB_START);
+ EmitOTelMetricsImpl emitOTelMetrics = new EmitOTelMetricsImpl();
+
emitOTelMetrics.emitLongCounterMetric(GaaSOpenTelemetryMetrics.GAAS_JOB_STATUS,
1L, attributes, finalProps);
Review Comment:
[nitpick] Consider reusing a single instance of EmitOTelMetricsImpl rather
than creating a new instance each time in order to improve maintainability and
reduce potential overhead.
```suggestion
this.emitOTelMetrics.emitLongCounterMetric(GaaSOpenTelemetryMetrics.GAAS_JOB_STATUS,
1L, attributes, finalProps);
```
Issue Time Tracking
-------------------
Worklog Id: (was: 972623)
Time Spent: 20m (was: 10m)
> Emit GaaS Executor OTel Metrics
> -------------------------------
>
> Key: GOBBLIN-2209
> URL: https://issues.apache.org/jira/browse/GOBBLIN-2209
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-metrics
> Reporter: Vivek Rai
> Assignee: Issac Buenrostro
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Emit GaaS Executor OTel Metrics
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
