Blazer-007 opened a new pull request, #4119: URL: https://github.com/apache/gobblin/pull/4119
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-XXX ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): Temporal heartbeat is sent periodically using ScheduledExecutorService but in case any exception is thrown while sending heartbeat from temporal it will kill the heartbeat runnable task and even though activity might be still running it will be killed after sometime when server doesn't receive any heartbeat from activity, to avoid this we can wrap the runnable to print exception instead so that next heartbeat events can be sent properly - Added `safeRunnable` in `ExecutorsUtils` - Refactored Activity codes to use `safeRunnable` ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: `testSafeRunnableRunsSuccessfully`,`testSafeRunnableHandlesException` ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
