abhishekmjain commented on code in PR #4130:
URL: https://github.com/apache/gobblin/pull/4130#discussion_r2272690150
##########
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java:
##########
@@ -698,8 +698,13 @@ public void executeImpl(JobExecutionContext context)
throws JobExecutionExceptio
} else {
jobProps.setProperty(ConfigurationKeys.ORCHESTRATOR_TRIGGER_EVENT_TIME_MILLIS_KEY,
String.valueOf(triggerTimeMillis));
- _log.info(jobSchedulerTracePrefixBuilder(jobProps) + "triggerTime:
{} nextTriggerTime: {} - Job triggered by "
- + "scheduler", triggerTimeMillis,
utcDateAsUTCEpochMillis(trigger.getNextFireTime()));
+ if(trigger.getNextFireTime() == null){
+ _log.info(jobSchedulerTracePrefixBuilder(jobProps) + "triggerTime:
{} nextTriggerTime: NA - Job triggered by "
+ + "scheduler", triggerTimeMillis);
+ } else {
+ _log.info(jobSchedulerTracePrefixBuilder(jobProps) + "triggerTime:
{} nextTriggerTime: {} - Job triggered by "
+ + "scheduler", triggerTimeMillis,
utcDateAsUTCEpochMillis(trigger.getNextFireTime()));
+ }
Review Comment:
nit: can you install gobblin codestyle and format the newly added code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
