Copilot commented on code in PR #4134:
URL: https://github.com/apache/gobblin/pull/4134#discussion_r2314368514
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/CopyEntity.java:
##########
@@ -54,6 +55,8 @@ public class CopyEntity implements HasGuid {
public static final Gson GSON = GsonInterfaceAdapter.getGson(Object.class);
+ private final Guid id = new Guid(UUID.randomUUID().toString().getBytes());
Review Comment:
The UUID is converted to string then to bytes, which is inefficient.
Consider using `UUID.randomUUID().toString().getBytes(StandardCharsets.UTF_8)`
to specify the charset explicitly, or better yet, use
`UUID.randomUUID().toString()` directly if the Guid constructor accepts strings.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
