Copilot commented on code in PR #4158:
URL: https://github.com/apache/gobblin/pull/4158#discussion_r2581531184
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -77,6 +77,9 @@ public class ConfigurationKeys {
public static final String DEFAULT_STATE_STORE_DB_JDBC_DRIVER =
"com.mysql.cj.jdbc.Driver";
public static final String STATE_STORE_DB_URL_KEY = "state.store.db.url";
public static final String STATE_STORE_DB_USER_KEY = "state.store.db.user";
+
Review Comment:
The new configuration constant `STATE_STORE_DB_SSL_MODE_ENABLED` lacks an
inline comment explaining its purpose, while other constants in this section
have comments (e.g., lines 63-67, 71-75).
Recommendation: Add a brief comment like:
```java
// Enable SSL mode (VERIFY_IDENTITY) for MySQL connections
public static final String STATE_STORE_DB_SSL_MODE_ENABLED =
"state.store.db.sslModeEnabled";
```
```suggestion
// Enable SSL mode (VERIFY_IDENTITY) for MySQL connections
```
##########
gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java:
##########
@@ -77,6 +77,9 @@ public class ConfigurationKeys {
public static final String DEFAULT_STATE_STORE_DB_JDBC_DRIVER =
"com.mysql.cj.jdbc.Driver";
public static final String STATE_STORE_DB_URL_KEY = "state.store.db.url";
public static final String STATE_STORE_DB_USER_KEY = "state.store.db.user";
+
+ public static final String STATE_STORE_DB_SSL_MODE_ENABLED =
"state.store.db.sslModeEnabled";
Review Comment:
The constant name `STATE_STORE_DB_SSL_MODE_ENABLED` does not follow the
established naming convention in this file. All other similar constants have a
`_KEY` suffix (e.g., `STATE_STORE_DB_URL_KEY`, `STATE_STORE_DB_USER_KEY`,
`STATE_STORE_DB_PASSWORD_KEY`, `STATE_STORE_DB_TABLE_KEY`).
Recommendation: Rename to `STATE_STORE_DB_SSL_MODE_ENABLED_KEY` for
consistency.
```suggestion
public static final String STATE_STORE_DB_SSL_MODE_ENABLED_KEY =
"state.store.db.sslModeEnabled";
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
