Blazer-007 commented on code in PR #4160:
URL: https://github.com/apache/gobblin/pull/4160#discussion_r2621935550
##########
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinYarnAppLauncher.java:
##########
@@ -999,6 +1000,37 @@ private static Config addDynamicConfig(Config config)
throws IOException {
}
}
+ private static Config addJarCachingConfig(Config config, FileSystem fs)
throws IOException {
+ // Check if JAR_CACHE_DIR is configured and exists
+ if (config.hasPath(GobblinYarnConfigurationKeys.JAR_CACHE_DIR)) {
+ Path jarCacheDir = new
Path(config.getString(GobblinYarnConfigurationKeys.JAR_CACHE_DIR));
+ if (fs.exists(jarCacheDir)) {
+ // JAR_CACHE_DIR exists, nothing to do
+ return config;
+ }
Review Comment:
We don't need to check existence of complete directory we should check only
the starting part of dir as complete directory will be created later on
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
