DaisyModi opened a new pull request, #4176: URL: https://github.com/apache/gobblin/pull/4176
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-2247 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): Worker status reporting uses gRPC calls to the Temporal service. `TemporalWorkflowClientFactory.createServiceInstance()` previously built `WorkflowServiceStubsOptions` without `setRpcRetryOptions()`, leaving the SDK's `DefaultStubServiceOperationRpcRetryOptions` in effect (~10s expiry). This is insufficient to survive 1-2 minute throttle bursts. **Changes:** - `GobblinTemporalConfigurationKeys`: Added 4 config keys under `gobblin.temporal.rpc.retry.options.*`, following the same pattern as the existing `gobblin.temporal.activity.retry.options.*` keys. - `TemporalWorkflowClientFactory`: Added `buildRpcRetryOptions(Config)` helper wired into `WorkflowServiceStubsOptions` via `.setRpcRetryOptions()`. Default values provide ~151.5s of cumulative retry budget (initialInterval=500ms, coefficient=2.0, maximumInterval=30s, maximumAttempts=10), covering a 2-minute throttle burst with buffer. All values are configurable via Typesafe Config. ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: `buildRpcRetryOptions` is a straightforward config-to-SDK-object mapping with no branching logic to unit test. Integration-level throttling behavior is exercised by existing Temporal end-to-end tests. ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
