DaisyModi opened a new pull request, #4180: URL: https://github.com/apache/gobblin/pull/4180
Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. - https://issues.apache.org/jira/browse/GOBBLIN-2247 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): Follow-up to #4176. The previous RPC retry defaults (`initialInterval=500ms`, `maximumInterval=30s`, `maximumAttempts=10`) provided ~2.5 minutes of cumulative retry budget — only marginally better than the Temporal SDK's built-in 1-minute expiration default (`DefaultStubServiceOperationRpcRetryOptions`). This was insufficient to survive sustained throttle bursts of up to 10 minutes observed in production. **Changes to default values in `GobblinTemporalConfigurationKeys`:** | Parameter | Old | New | Rationale | |---|---|---|---| | `initialInterval` | 500ms | 1000ms | Less aggressive on a throttled server | | `maximumInterval` | 30s | 60s | Sufficient spacing during sustained throttling | | `backoffCoefficient` | 2.0 | 2.0 | Unchanged | | `maximumAttempts` | 10 | 15 | Fewer attempts needed thanks to larger max interval | With `initialInterval=1s`, `coefficient=2.0`, `maximumInterval=60s`, `maximumAttempts=15`: - Attempts 1–6: 1 + 2 + 4 + 8 + 16 + 32 = 63s (hits 60s cap at attempt 7) - Attempts 7–15: 9 × 60s = 540s - **Total: ~603s (~10 min)** All values remain configurable via Typesafe Config. ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Config-only change — no logic changes. `buildRpcRetryOptions` is unchanged; only the default constants are tuned. ### Commits - [x] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)". -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
