debabhishek53 commented on code in PR #4185:
URL: https://github.com/apache/gobblin/pull/4185#discussion_r3055684017
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSource.java:
##########
@@ -152,10 +154,18 @@ public class IcebergSource extends
FileBasedSource<String, FileAwareInputStream>
/**
* Optional {@link DateTimeFormatter} pattern controlling how the partition
value is rendered.
*
- * <p>When {@code iceberg.filter.date=CURRENT_DATE} the reference datetime is
- * {@link java.time.LocalDateTime#now()}, so a pattern that includes {@code
HH} will embed
- * the current clock-hour automatically — no separate hour config is needed.
- * For a specific date (e.g. {@code 2025-04-03}), the time defaults to
midnight (00:00).
+ * <p><b>CURRENT_DATE behaviour differs between the two paths:</b>
+ * <ul>
+ * <li>When this property <em>is</em> set, {@code CURRENT_DATE} resolves to
Review Comment:
Added the property name as iceberg.partition.value.datetime.format
##########
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/copy/iceberg/IcebergSource.java:
##########
@@ -152,10 +154,18 @@ public class IcebergSource extends
FileBasedSource<String, FileAwareInputStream>
/**
* Optional {@link DateTimeFormatter} pattern controlling how the partition
value is rendered.
*
- * <p>When {@code iceberg.filter.date=CURRENT_DATE} the reference datetime is
- * {@link java.time.LocalDateTime#now()}, so a pattern that includes {@code
HH} will embed
- * the current clock-hour automatically — no separate hour config is needed.
- * For a specific date (e.g. {@code 2025-04-03}), the time defaults to
midnight (00:00).
+ * <p><b>CURRENT_DATE behaviour differs between the two paths:</b>
+ * <ul>
+ * <li>When this property <em>is</em> set, {@code CURRENT_DATE} resolves to
+ * {@link java.time.LocalDateTime#now()}, so a pattern that includes
{@code HH} embeds the
+ * live clock-hour automatically — useful for truly hourly-partitioned
tables.</li>
+ * <li>When this property is <em>absent</em> (legacy path), {@code
CURRENT_DATE} resolves to
+ * {@link java.time.LocalDate#now()} at midnight (00:00), preserving
the pre-PR behaviour
Review Comment:
Added the property name as iceberg.partition.value.datetime.format
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
