pratapaditya04 opened a new pull request, #4194: URL: https://github.com/apache/gobblin/pull/4194
## Summary - Deadline reminder JobKeys previously included the lease event time, but the `DagActionStore` DELETE event payload omits event time, leaving `DagManagementDagActionStoreChangeMonitor` unable to cancel a still-pending deadline reminder. - Re-keys deadline reminders by `(flowGroup, flowName, flowExecutionId, jobName, dagActionType)` only, and replaces any pre-existing entry on schedule to avoid `ObjectAlreadyExistsException` when the duplicate-insert path (`DagProcUtils.sendEnforce*DeadlineDagAction`) races with an out-of-order change event. - Retry reminders still include event time and are intentionally not unscheduled on DELETE; orphaned retries fire harmlessly since the lease arbiter sees the action is gone and drops the work. ## Test plan - [ ] `DagActionReminderSchedulerTest` covers: deadline reminder schedule/unschedule by dagAction only, replace-on-duplicate-schedule, retry reminder still keyed with event time - [ ] Run `./gradlew :gobblin-service:test --tests "*DagActionReminderSchedulerTest*"` - [ ] Manual: verify `ENFORCE_JOB_START_DEADLINE` / `ENFORCE_FLOW_FINISH_DEADLINE` reminders are unscheduled when the corresponding DagActionStore row is deleted -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
