ibuenros commented on a change in pull request #2563: [GOBBLIN-691] Make
format-specific component pluggable in compaction
URL: https://github.com/apache/incubator-gobblin/pull/2563#discussion_r261352026
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/CompactorFactory.java
##########
@@ -29,6 +29,7 @@
/**
* A factory responsible for creating {@link Compactor}s.
+ * @deprecated
Review comment:
The annotation on javadoc is intended to explain reasons / alternatives to
this API (which you should do). The actual deprecation annotation goes outside
of the javadoc (`@Deprecated`)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
