[
https://issues.apache.org/jira/browse/GOBBLIN-691?focusedWorklogId=206092&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-206092
]
ASF GitHub Bot logged work on GOBBLIN-691:
------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Feb/19 22:22
Start Date: 28/Feb/19 22:22
Worklog Time Spent: 10m
Work Description: ibuenros commented on pull request #2563: [GOBBLIN-691]
Make format-specific component pluggable in compaction
URL: https://github.com/apache/incubator-gobblin/pull/2563#discussion_r261407910
##########
File path:
gobblin-compaction/src/main/java/org/apache/gobblin/compaction/mapreduce/CompactionAvroJobConfigurator.java
##########
@@ -138,25 +106,27 @@ private Schema getKeySchema(Job job, Schema topicSchema)
throws IOException {
keySchema = AvroUtils.parseSchemaFromFile(keySchemaFile, this.fs);
} catch (IOException e) {
log.error("Failed to parse avro schema from " + keySchemaFile
- + ", using key attributes in the schema for compaction");
- keySchema =
AvroUtils.removeUncomparableFields(MRCompactorAvroKeyDedupJobRunner.getKeySchema(topicSchema)).get();
+ + ", using key attributes in the schema for compaction");
+ keySchema =
+
AvroUtils.removeUncomparableFields(MRCompactorAvroKeyDedupJobRunner.getKeySchema(topicSchema)).get();
}
if (!MRCompactorAvroKeyDedupJobRunner.isKeySchemaValid(keySchema,
topicSchema)) {
log.warn(String.format("Key schema %s is not compatible with record
schema %s.", keySchema, topicSchema)
- + "Using key attributes in the schema for compaction");
- keySchema =
AvroUtils.removeUncomparableFields(MRCompactorAvroKeyDedupJobRunner.getKeySchema(topicSchema)).get();
+ + "Using key attributes in the schema for compaction");
+ keySchema =
+
AvroUtils.removeUncomparableFields(MRCompactorAvroKeyDedupJobRunner.getKeySchema(topicSchema)).get();
}
} else {
log.info("Property " +
MRCompactorAvroKeyDedupJobRunner.COMPACTION_JOB_AVRO_KEY_SCHEMA_LOC
- + " not provided. Using key attributes in the schema for
compaction");
+ + " not provided. Using key attributes in the schema for
compaction");
keySchema =
AvroUtils.removeUncomparableFields(MRCompactorAvroKeyDedupJobRunner.getKeySchema(topicSchema)).get();
}
return keySchema;
}
- private void configureSchema(Job job) throws IOException {
+ protected void configureSchema(Job job) throws IOException {
Review comment:
Please add `@Override` annotation.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 206092)
Time Spent: 50m (was: 40m)
> Make compaction implementation format-insensitive
> -------------------------------------------------
>
> Key: GOBBLIN-691
> URL: https://issues.apache.org/jira/browse/GOBBLIN-691
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Lei Sun
> Priority: Major
> Time Spent: 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
