ibuenros commented on a change in pull request #2576: [GOBBLIN-706]enable dynamic mappers URL: https://github.com/apache/incubator-gobblin/pull/2576#discussion_r268254287
########## File path: gobblin-api/src/main/java/org/apache/gobblin/configuration/ConfigurationKeys.java ########## @@ -617,6 +617,7 @@ /** Specifies a static location in HDFS to upload jars to. Useful for sharing jars across different Gobblin runs.*/ public static final String MR_JARS_DIR = "mr.jars.dir"; public static final String MR_JOB_MAX_MAPPERS_KEY = "mr.job.max.mappers"; + public static final String TARGET_MAPPER_SIZE = "target.mapper.size"; Review comment: Can you add the `mr` prefix to the key similar to the other configuration keys? e.g. `mr.target.mapper.size` ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
