[ https://issues.apache.org/jira/browse/GOBBLIN-707?focusedWorklogId=222822&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-222822 ]
ASF GitHub Bot logged work on GOBBLIN-707: ------------------------------------------ Author: ASF GitHub Bot Created on: 04/Apr/19 05:58 Start Date: 04/Apr/19 05:58 Worklog Time Spent: 10m Work Description: jhsenjaliya commented on pull request #2578: [GOBBLIN-707] rewrite gobblin script to combine all modes and command URL: https://github.com/apache/incubator-gobblin/pull/2578#discussion_r272026110 ########## File path: conf/yarn/application.conf ########## @@ -22,15 +22,18 @@ gobblin.yarn.app.name=GobblinYarn gobblin.yarn.app.master.memory.mbs=256 gobblin.yarn.initial.containers=2 gobblin.yarn.container.memory.mbs=512 -gobblin.yarn.conf.dir=<directory where Gobblin on Yarn related configuration files are located> -gobblin.yarn.lib.jars.dir=<directory where Gobblin on Yarn lib jars are located> -gobblin.yarn.app.master.files.local=${gobblin.yarn.conf.dir}"/log4j-yarn.properties,"${gobblin.yarn.conf.dir}"/application.conf,"${gobblin.yarn.conf.dir}"/reference.conf" +gobblin.yarn.conf.dir=/tools/gobblin-dist/conf/yarn/ Review comment: this is missed, let me change this to `gobblin.yarn.conf.dir=${GOBBLIN_HOME}/conf/yarn/` will be better than having <informational values> btw, thanks for catching this, this was my local config. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 222822) Time Spent: 2h 10m (was: 2h) > combine & standardize all gobblin scripts into one master script & > restructure configs accordingly > -------------------------------------------------------------------------------------------------- > > Key: GOBBLIN-707 > URL: https://issues.apache.org/jira/browse/GOBBLIN-707 > Project: Apache Gobblin > Issue Type: Improvement > Reporter: Jay Sen > Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > > gobblin supports multiple modes of executions ( CLI, Standalone, > cluster-master, cluster-worker, AWS, YARN, MR ) and there is a individual > script for each of them. > 1. there can be one gobblin.sh script > {{gobblin.sh <command> <params>}} > {{gobblin.sh <service-name> <start|stop|status>}} > {{commands values: admin, cli, statestore-check, statestore-clean, > historystore-manager}} > {{service values: standalone, cluster-master, cluster-worker, aws, yarn, mr, > service}} > 2. Also configs needs to be structured and deduped accordingly. > -- This message was sent by Atlassian JIRA (v7.6.3#76005)