autumnust opened a new pull request #2613: [GOBBLIN-748]Craftsmanship code cleaning in Gobblin Service Code URL: https://github.com/apache/incubator-gobblin/pull/2613 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! Essentially a bunch of renaming, moving configurations key around. Things that we should agree on: - Configuration keys should always placed in the class where they are relevant, instead of `ConfigurationKeys.java` or similar things. We should definitely stop doing that. - Naming of `FSFlowCatalog` is misleading. In fact it should be `FsTemplateFlowCatalog`. Also, it should not extend `FsJobCatalog`. The missing piece is a `FsCatalogBase` that implement all FileSystem related basic functionality, and have `Template` and `Job` FsCatalog extending that base implementation with it own interface. ### JIRA - [x ] My PR addresses the following [Gobblin JIRA] - https://issues.apache.org/jira/browse/GOBBLIN-748 ### Description - [ x] Here are some details about my PR, including screenshots (if applicable): ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how"
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
