[
https://issues.apache.org/jira/browse/GOBBLIN-762?focusedWorklogId=238612&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-238612
]
ASF GitHub Bot logged work on GOBBLIN-762:
------------------------------------------
Author: ASF GitHub Bot
Created on: 07/May/19 15:53
Start Date: 07/May/19 15:53
Worklog Time Spent: 10m
Work Description: shirshanka commented on pull request #2626:
[GOBBLIN-762] Add automatic scaling for Gobblin on YARN
URL: https://github.com/apache/incubator-gobblin/pull/2626#discussion_r281681669
##########
File path:
gobblin-yarn/src/main/java/org/apache/gobblin/yarn/GobblinApplicationMaster.java
##########
@@ -82,13 +89,22 @@ public GobblinApplicationMaster(String applicationName,
ContainerId containerId,
.addService(gobblinYarnLogSource.buildLogCopier(this.config,
containerId, this.fs, this.appWorkDir));
}
- this.applicationLauncher
- .addService(buildYarnService(this.config, applicationName,
this.applicationId, yarnConfiguration, this.fs));
+ this.yarnService = buildYarnService(this.config, applicationName,
this.applicationId, yarnConfiguration, this.fs);
+ this.applicationLauncher.addService(this.yarnService);
if (UserGroupInformation.isSecurityEnabled()) {
LOGGER.info("Adding YarnContainerSecurityManager since security is
enabled");
this.applicationLauncher.addService(buildYarnContainerSecurityManager(this.config,
this.fs));
}
+
+ // Add additional services
+ List<String> serviceClassNames = ConfigUtils.getStringList(this.config,
+ GobblinYarnConfigurationKeys.APP_MASTER_SERVICE_CLASSES);
+
+ for (String serviceClassName : serviceClassNames) {
+ Class<?> serviceClass = Class.forName(serviceClassName);
+ this.applicationLauncher.addService((Service)
GobblinConstructorUtils.invokeLongestConstructor(serviceClass, this));
Review comment:
why longest constructor?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 238612)
Time Spent: 1h 20m (was: 1h 10m)
> Add automatic scaling for Gobblin on YARN
> -----------------------------------------
>
> Key: GOBBLIN-762
> URL: https://issues.apache.org/jira/browse/GOBBLIN-762
> Project: Apache Gobblin
> Issue Type: Task
> Reporter: Hung Tran
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> Gobblin on YARN needs a way to scale up and down the containers based on the
> workload.
> Added `YarnAutoScalingManager` which can be started by the
> `GobblinApplicationMaster` by setting the
> `gobblin.yarn.app.master.serviceClasses` configuration. This class runs a
> scheduled task with a default interval of 60 seconds to detect the number of
> required partitions for the workflows submitted to Helix. It will request the
> `YarnService` to scale to a computed number of containers. If the requested
> number of containers is higher than the YarnService has previously requested
> then it will request more containers. If the requested count is less than the
> current number of allocated containers then it will free any unused
> containers.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
