[ https://issues.apache.org/jira/browse/GOBBLIN-759?focusedWorklogId=240881&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-240881 ]
ASF GitHub Bot logged work on GOBBLIN-759: ------------------------------------------ Author: ASF GitHub Bot Created on: 13/May/19 05:41 Start Date: 13/May/19 05:41 Worklog Time Spent: 10m Work Description: amarnathkarthik commented on pull request #2623: [GOBBLIN-759] Added feature to support DistCP to copy files modified in last n days URL: https://github.com/apache/incubator-gobblin/pull/2623 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [x] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-759] My Added feature to support DistCP to copy files modified in last n days" - https://issues.apache.org/jira/browse/GOBBLIN-759 ### Description - [x] Here are some details about my PR, including screenshots (if applicable): 1. Added feature to DistCP the files which were modified in last n days within the lookback period. 2. This feature allows to copy only the modified files even when non modified files not at the destination. 3. Leverage existing TimestampBasedCopyableDataset to find the dataset and uses SelectBtwModDataTimeBasedCopyableFileFilter CopyableFilter implementation to filter the files that were modified in last n days. ### Tests - [x] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: 1. Added TimestampBasedCopyableDatasetTest.testCopyWithFilter test case to test 1 modified and 1 non-modified scenario. ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how" ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 240881) Time Spent: 1h (was: 50m) > DistCP files modified in last n days within a look back period > -------------------------------------------------------------- > > Key: GOBBLIN-759 > URL: https://issues.apache.org/jira/browse/GOBBLIN-759 > Project: Apache Gobblin > Issue Type: Improvement > Reporter: Karthik Amarnath > Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > > *Feature Request:* > # DistCP only the files modified in last n days within the look back window. > # DistCP will copy only the files modified even when the source file which > were NOT modified in last n days in the destination directory. -- This message was sent by Atlassian JIRA (v7.6.3#76005)