ZihanLi58 opened a new pull request #2637: [GOBBLIN-772]Implement Schema Comparison Strategy during Disctp URL: https://github.com/apache/incubator-gobblin/pull/2637 Dear Gobblin maintainers, Please accept this PR. I understand that it will not be reviewed until I have checked off all the steps below! ### JIRA - [ ] My PR addresses the following [Gobblin JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR" - https://issues.apache.org/jira/browse/GOBBLIN-772 ### Description - [ ] Here are some details about my PR, including screenshots (if applicable): We need a schema comparison strategy to make sure the real schema and the expected schema have matching field names and types. ### Tests - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason: Make the real schema and expected schema have different name or type and make sure the method return false. And make they have matching name and type but not the same doc and make sure the method return true. ### Commits - [ ] My commits all reference JIRA issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)": 1. Subject is separated from body by a blank line 2. Subject is limited to 50 characters 3. Subject does not end with a period 4. Subject uses the imperative mood ("add", not "adding") 5. Body wraps at 72 characters 6. Body explains "what" and "why", not "how"
---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] With regards, Apache Git Services
