sv2000 commented on a change in pull request #2647: [GOBBLIN-781] Skeleton for
GaaS DR mode clean transition
URL: https://github.com/apache/incubator-gobblin/pull/2647#discussion_r289204291
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/scheduler/GobblinServiceJobScheduler.java
##########
@@ -170,6 +195,19 @@ private void scheduleSpecsFromCatalog() {
}
}
+ /**
+ * In DR-mode, the running {@link FlowSpec} will all be cancelled and
rescheduled.
+ * We will need to make sure that running {@link FlowSpec}s' state are
cleared, and corresponding running jobs are
+ * killed before rescheduling them.
+ * @param drUris The uris that applicable for DR discovered from FlowCatalog.
+ */
+ private void clearRunningFlowState(Iterator<URI> drUris) {
Review comment:
Should the DR related failover handling be moved to a separate class? For
now, you are triggering it based on config. In the future, we might have a REST
end-point or some other mechanism for triggering a fail over, without needing a
service restart.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
With regards,
Apache Git Services
