ZihanLi58 commented on a change in pull request #2672: [GOBBLIN-806]Enable
metrics reporter during dataset discovery for retention job
URL: https://github.com/apache/incubator-gobblin/pull/2672#discussion_r294967654
##########
File path:
gobblin-data-management/src/main/java/org/apache/gobblin/data/management/retention/profile/MultiCleanableDatasetFinder.java
##########
@@ -52,6 +53,10 @@ public MultiCleanableDatasetFinder(FileSystem fs,
Properties jobProps) {
super(fs, jobProps);
Review comment:
In the super class MultiDatasetFinder, the construction
MultiDatasetFinder(fs, jobProps) will create a default eventSubmitter and call
MultiDatasetFinder() which accepts eventSubmitter as an argument. So I think
there is no need to create a default eventSubmitter here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
