[
https://issues.apache.org/jira/browse/GOBBLIN-808?focusedWorklogId=266139&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-266139
]
ASF GitHub Bot logged work on GOBBLIN-808:
------------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/19 21:44
Start Date: 24/Jun/19 21:44
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2674: [GOBBLIN-808]
implement azkaban flow cancel when dag manager is enabled
URL: https://github.com/apache/incubator-gobblin/pull/2674#discussion_r296928685
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/orchestration/DagManager.java
##########
@@ -294,10 +335,30 @@ public synchronized void setActive(boolean active) {
@Override
public void run() {
try {
- Object nextItem = queue.poll();
+ String nextDagToCancel = cancelQueue.poll();
+ //Poll the cancelQueue for a new Dag to cancel.
+ if (nextDagToCancel != null) {
Review comment:
Can the cancellation loginc in lines 340-355 be moved to a separate method?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 266139)
Time Spent: 2h 40m (was: 2.5h)
> implement azkaban job cancellation in Gobblin Service
> -----------------------------------------------------
>
> Key: GOBBLIN-808
> URL: https://issues.apache.org/jira/browse/GOBBLIN-808
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
