[
https://issues.apache.org/jira/browse/GOBBLIN-810?focusedWorklogId=268214&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-268214
]
ASF GitHub Bot logged work on GOBBLIN-810:
------------------------------------------
Author: ASF GitHub Bot
Created on: 27/Jun/19 05:02
Start Date: 27/Jun/19 05:02
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2675: [GOBBLIN-810]
Include flow edge ID in job name
URL: https://github.com/apache/incubator-gobblin/pull/2675#discussion_r298006264
##########
File path:
gobblin-service/src/test/java/org/apache/gobblin/service/modules/flow/MultiHopFlowCompilerTest.java
##########
@@ -244,7 +244,7 @@ public void testCompileFlow() throws URISyntaxException,
IOException {
String flowGroup = "testFlowGroup";
String flowName = "testFlowName";
String expectedJobName1 =
Joiner.on(JobExecutionPlan.Factory.JOB_NAME_COMPONENT_SEPARATION_CHAR).
- join(flowGroup, flowName, "Distcp", "LocalFS-1", "HDFS-1");
+ join(flowGroup, flowName, "Distcp", "LocalFS-1:HDFS-1:localToHdfs");
Review comment:
Maybe better to change GitFlowGraphMonitor.FLOW_EDGE_LABEL_JOINER_CHAR to
use a character that is not ":". Perhaps "_"? ":" will not work well with FS
based Job Status store, where job name is used in the filename.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 268214)
Time Spent: 40m (was: 0.5h)
> Include flow edge ID in job name
> --------------------------------
>
> Key: GOBBLIN-810
> URL: https://issues.apache.org/jira/browse/GOBBLIN-810
> Project: Apache Gobblin
> Issue Type: Bug
> Reporter: Jack Moseley
> Priority: Major
> Time Spent: 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
