[
https://issues.apache.org/jira/browse/GOBBLIN-816?focusedWorklogId=269506&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-269506
]
ASF GitHub Bot logged work on GOBBLIN-816:
------------------------------------------
Author: ASF GitHub Bot
Created on: 28/Jun/19 20:18
Start Date: 28/Jun/19 20:18
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2680: GOBBLIN-816:
Implement a workaround to abort Helix TaskDriver#getWork…
URL: https://github.com/apache/incubator-gobblin/pull/2680
…flows() after a timeout
Dear Gobblin maintainers,
Please accept this PR. I understand that it will not be reviewed until I
have checked off all the steps below!
### JIRA
- [x] My PR addresses the following [Gobblin
JIRA](https://issues.apache.org/jira/browse/GOBBLIN/) issues and references
them in the PR title. For example, "[GOBBLIN-XXX] My Gobblin PR"
- https://issues.apache.org/jira/browse/GOBBLIN-816
### Description
- [x] Here are some details about my PR, including screenshots (if
applicable):
TaskDriver#getWorkflows() can hang indefinitely if there are ZK connectivity
issues. This impacts the ability to cancel/restart Helix workflows running
inside a Gobblin cluster. The workaround should kill the thread running
getWorkflows() after a timeout.
### Tests
- [x] My PR adds the following unit tests __OR__ does not need testing for
this extremely good reason:
End to end test.
### Commits
- [x] My commits all reference JIRA issues in their subject lines, and I
have squashed multiple commits if they address the same issue. In addition, my
commits follow the guidelines from "[How to write a good git commit
message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
2. Subject is limited to 50 characters
3. Subject does not end with a period
4. Subject uses the imperative mood ("add", not "adding")
5. Body wraps at 72 characters
6. Body explains "what" and "why", not "how"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 269506)
Time Spent: 10m
Remaining Estimate: 0h
> Implement a workaround to abort Helix TaskDriver#getWorkflows() after a
> timeout
> -------------------------------------------------------------------------------
>
> Key: GOBBLIN-816
> URL: https://issues.apache.org/jira/browse/GOBBLIN-816
> Project: Apache Gobblin
> Issue Type: Improvement
> Components: gobblin-cluster
> Affects Versions: 0.15.0
> Reporter: Sudarshan Vasudevan
> Assignee: Hung Tran
> Priority: Major
> Fix For: 0.15.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> TaskDriver#getWorkflows() can hang indefinitely if there are ZK connectivity
> issues. This impacts the ability to cancel/restart Helix workflows running
> inside a Gobblin cluster. The workaround should kill the thread running
> getWorkflows() after a timeout.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
