[ 
https://issues.apache.org/jira/browse/GOBBLIN-750?focusedWorklogId=274211&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274211
 ]

ASF GitHub Bot logged work on GOBBLIN-750:
------------------------------------------

                Author: ASF GitHub Bot
            Created on: 09/Jul/19 16:57
            Start Date: 09/Jul/19 16:57
    Worklog Time Spent: 10m 
      Work Description: zxcware commented on pull request #2615: [GOBBLIN-750] 
remove usage of depricated DatasetResolver and DatasetResolverFactory
URL: https://github.com/apache/incubator-gobblin/pull/2615#discussion_r301692876
 
 

 ##########
 File path: 
gobblin-api/src/main/java/org/apache/gobblin/dataset/DescriptorResolver.java
 ##########
 @@ -31,5 +31,20 @@
    * @param state configuration that helps resolve job specific descriptor
    * @return resolved descriptor for the job or {@code null} if failed to 
resolve
    */
-  Descriptor resolve(Descriptor raw, State state);
+  DatasetDescriptor resolve(DatasetDescriptor raw, State state);
 
 Review comment:
   Can we remove this?
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

            Worklog Id:     (was: 274211)
            Time Spent: 10m
    Remaining Estimate: 0h

> remove usage of depricated DatasetResolver and DatasetResolverFactory
> ---------------------------------------------------------------------
>
>                 Key: GOBBLIN-750
>                 URL: https://issues.apache.org/jira/browse/GOBBLIN-750
>             Project: Apache Gobblin
>          Issue Type: Improvement
>    Affects Versions: 0.15.0
>            Reporter: Jay Sen
>            Priority: Minor
>             Fix For: 0.15.0
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> {{DatasetResolver}} and {{DatasetResolverFactory}} both are marked as 
> deprecated.
> should remove the usage for next version, before there are more such resolver 
> added for lineage functionality.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to