[
https://issues.apache.org/jira/browse/GOBBLIN-808?focusedWorklogId=274633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-274633
]
ASF GitHub Bot logged work on GOBBLIN-808:
------------------------------------------
Author: ASF GitHub Bot
Created on: 10/Jul/19 04:23
Start Date: 10/Jul/19 04:23
Worklog Time Spent: 10m
Work Description: sv2000 commented on pull request #2674: [GOBBLIN-808]
implement azkaban flow cancel when dag manager is enabled
URL: https://github.com/apache/incubator-gobblin/pull/2674#discussion_r301880633
##########
File path:
gobblin-service/src/main/java/org/apache/gobblin/service/modules/spec/JobExecutionPlanListSerializer.java
##########
@@ -83,6 +83,14 @@ public JsonElement serialize(List<JobExecutionPlan> src,
Type typeOfSrc, JsonSer
String executionStatus = jobExecutionPlan.getExecutionStatus().name();
jobExecutionPlanJson.addProperty(SerializationConstants.EXECUTION_STATUS_KEY,
executionStatus);
+ try {
+ String jobExecutionFuture =
jobExecutionPlan.getSpecExecutor().getProducer().get()
+
.serializeAddSpecResponse(jobExecutionPlan.getJobFuture().orNull());
+
jobExecutionPlanJson.addProperty(SerializationConstants.JOB_EXECUTION_FUTURE,
jobExecutionFuture);
+ } catch (InterruptedException | ExecutionException e) {
+ log.warn("Error during serialization of JobExecutionFuture.");
Review comment:
I think I had a comment earlier about this. Not sure, if it got lost. But
should we propagate the exception? It may not be much use persisting a dag
which cannot be deserialized back.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 274633)
Time Spent: 5h 40m (was: 5.5h)
> implement azkaban job cancellation in Gobblin Service
> -----------------------------------------------------
>
> Key: GOBBLIN-808
> URL: https://issues.apache.org/jira/browse/GOBBLIN-808
> Project: Apache Gobblin
> Issue Type: Improvement
> Reporter: Arjun Singh Bora
> Priority: Major
> Time Spent: 5h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
